Build Decision Point with Code

Question

question

Rohan V3 asked Sep 3, '21 Matthew Gillespie commented Sep 7, '21

Build Decision Point with Code

MDR is the library which has 3 DPs that I am using to build the model. The conveyor has an on reset code which deletes the DPs and creates new ones. If you start a new model and run the code the first time it works. After that, the model keeps crashing everytime I hit reset.

Software Version:

FlexSim 21.0.4

conveyor code conveyorsystem decision point flexsim 21.0.4

mdr.fsl (2.6 KiB)

test-model-1.fsm (41.1 KiB)

· 6

Matthew Gillespie ♦♦ commented · Sep 04, 2021 at 10:56 PM

@Rohan V3 What do you do after you start a new model? I added the conveyor to the user library and then dragged out the conveyor in a new model, and reset the labels and it seems to work fine. I'm not seeing any crashing issues. Can you tell me the exact steps you're doing?

0 ·

Jason Lightfoot ♦ Matthew Gillespie ♦♦ commented · Sep 06, 2021 at 09:57 AM

And it works in you test model too in 21.0.8. Setting the 'Built' label to zero each time to force the rebuild.

0 ·

Rohan V3 Jason Lightfoot ♦ commented · Sep 07, 2021 at 04:02 PM

Interesting.. @Matthew Gillespie Did you try changing the conveyor length? It crashes when I change the length, increase or decrease it. Change the conveyor length label on the conveyor. If it still works for you, can you attach your model and I can see if that file works.

0 ·

Show more comments

Answer 1 · 2021-09-07T20:05:01Z

Matthew Gillespie answered Sep 7, '21 Matthew Gillespie commented Sep 7, '21

I cleaned up your script to use better array access and methods and I'm no longer seeing the crashing issue. Array.push() is better than making an array of a single thing and appending that array.

Object current = ownerobject(c);
Array dps = current.DP;

// Delete Existing DPs
while (dps.length)
    dps.pop().destroy();

// Set Conveyor Length
current.size.x = current.Conv_Length;
function_s(current,"finalizeSpatialChanges");

//Create Start DP
treenode startdp = createinstance(maintree().find("project/userlibrary/MDR/Start DP"), current);
setloc(startdp, current.zone_Length - 7.875,0,0);
dps.push(startdp);
function_s(startdp,"finalizeSpatialChanges");

//Create Intermediate DP
int dpnum = (current.Conv_Length/current.zone_Length) - 2;

for (int i = 1;i<=dpnum;i++){
    treenode mdrdp = createinstance(maintree().find("project/userlibrary/MDR/MDR DP"), current);
    double dist_along_conv;
    dist_along_conv = (i+1)*current.zone_Length - 7.875;
    setloc(mdrdp, dist_along_conv,0,0);
    dps.push(mdrdp);        
    function_s(mdrdp,"finalizeSpatialChanges");

    //function_s(current,"finalizeSpatialChanges");
}

// Create END DP
treenode Enddp = createinstance(maintree().find("project/userlibrary/MDR/End DP"), current);
setloc(Enddp, current.Conv_Length - 7.875,0,0);
dps.push(Enddp);
function_s(Enddp,"finalizeSpatialChanges");

· 2

Rohan V3 commented · Sep 07, 2021 at 08:46 PM

Great! this works. Couple of questions:

Were you able to replicate the crashing? Was the append array the issue?

0 ·

Matthew Gillespie ♦♦ Rohan V3 commented · Sep 07, 2021 at 09:47 PM

@Rohan V3 Yes, I was able to replicate FlexSim hanging. I'm not totally sure what the issue was, but started cleaning up your code to narrow down the issue and after making the above changes to your code I stopped seeing the issue.

0 ·

question