Parantheses in switch statement in Flexscript

Question

question

Serge A asked Feb 14 2017 at 9:42 AM Serge A commented Feb 16 2017 at 9:07 AM

Parantheses in switch statement in Flexscript

I noticed that Flexscript (as of ver. 2017), doesn't support parentheses around the case values. The following example cannot be built:

#define FOO (1)  // follow the best practice of C macros here
#define BAR (2)
 
int n = 2;
switch (n) {
    case FOO: // <-- syntax error
        pt("foo"); pr();
        break;
    case BAR:
        pt("bar"); pr();
        break;
}

The error is:

syntax error, unexpected '(', expecting integer or hexadecimal integer or '-'

On a related note, what is the recommended way to have multiple numeric or string constants defined and shared between multiple nodefunctions? There are Global Macros and Global Variables, but is there a way to avoid polluting the global namespace and not having to copy-paste pages of code?

Software Version:

FlexSim 17.0.1

flexscript macro switch statement define

______

Cookie preferences

Your privacy is important to us and so is an optimal experience. To help us customize information and build applications, we collect data about your use of this site.

May we collect and use your data?

Learn more about the Third Party Services we use and our Privacy Statement.

Strictly necessary – required for our site to work and to provide services to you

These cookies allow us to record your preferences or login information, respond to your requests or fulfill items in your shopping cart.

YES

Improve your experience – allows us to show you what is relevant to you

These cookies enable us to provide enhanced functionality and personalization. They may be set by us or by third party providers whose services we use to deliver information and experiences tailored to you. If you do not allow these cookies, some or all of these services may not be available for you.

YES

NO

Customize your advertising – permits us to offer targeted advertising to you

These cookies collect data about you based on your activities and interests in order to show you relevant ads and to track effectiveness. By collecting this data, the ads you see will be more tailored to your interests. If you do not allow these cookies, you will experience less targeted advertising.

YES

NO

Are you sure you want a less customized experience?

We can access your data only if you select "yes" for the categories on the previous screen. This lets us tailor our marketing so that it's more relevant for you. You can change your settings at any time by visiting our privacy statement

Your experience. Your choice.

We care about your privacy. The data we collect helps us understand how you use our products, what information you might be interested in, and what we can improve to make your engagement with Autodesk more rewarding.

May we collect and use your data to tailor your experience?

Explore the benefits of a customized experience by managing your privacy settings for this site or visit our Privacy Statement to learn more about your options.

Answer 1 · 2017-02-15T00:02:00Z

Matt Long answered Feb 15 2017 at 12:02 AM Serge A commented Feb 16 2017 at 9:07 AM

Not sure I've ever seen a switch statement written with parenthesis around the cases. Remove the parenthesis and you'll be just fine.

As for sharing numeric/string constants between multiple functions, the only way to do this is to define it as a global macro or global variable. There are ways of making 'hidden' global variables using Model Libraries. You can refer to the Miscellaneous / Custom Libraries section of the user manual for information on creating Model Libraries.

· 3

Serge A commented · Feb 15 2017 at 9:02 AM

Thank you for pointing to Miscellaneous / ModelLibraries node as a way to hide global data. That answers my second question.

As for the first one, it's not really a question, but rather an observation of an inconsistency in the language parser implementation and a request for enhancement. ((2) + (2)) is a valid expression elsewhere. For instance, it's a valid expression in the if statement. I don't see why it shouldn't be allowed in switch-case statements.

The workarounds (removing parentheses or using if statements instead of switch in flexscript) are obvious, but the point is, it may be desirable to keep parentheses around #define values when those are expressions themselves to make sure the order of operations is always correct. The following is an example of when not adding parentheses in macro definitions may have unforeseen consequences elsewhere in the code:

#define VALUE 2
#define BAD_MACRO VALUE > 2
#define GOOD_MACRO ((VALUE) > 2)
 
int wrong_condition = BAD_MACRO - 1;    // +1.0
int correct_condition = GOOD_MACRO - 1; // -1.0
 
// unfortunately, GOOD_MACRO can be used in IF, but not in CASE

1 ·

Phil BoBo ♦♦ Serge A commented · Feb 15 2017 at 5:28 PM

I'll add a note to the dev list to look into how we can handle expressions that evaluate to a constant integer in switch case statements better.

For now, you need to use an integer literal in a switch case statement; not an expression that evaluates to a constant integer.

The following is valid code in C++, but won't build with FlexScript:

#define VALUE (2)
int fred = 5;
int bob = 0;
switch (fred)
{
case (1):
	bob = 1;
	break;
case VALUE:
	bob = 2;
	break;
case 2 + 3:
	bob = 5;
	break;
default:
	bob = 3;
}
return bob;

0 ·

Serge A Phil BoBo ♦♦ commented · Feb 16 2017 at 9:07 AM

Thank you. That's very kind of you.

0 ·

question