The OnDestroy code is executed two times when an object is deleted

Question

question

G. Moser asked Oct 3, '23 Matthew Gillespie commented Dec 7, '23

The OnDestroy code is executed two times when an object is deleted

I am currently working on an user library and I needed a script to be executed when an object of my library is deleted. Therefore I have added an OnDestroy node in the behaviour/eventfunctions node. Although it works fine in the 23.1 version, in latest version (23.2.1) it gives me an error. This error occurs because the code is executed two times instead of once and the second time it can not access the nodes because the object related is already destroyed. I make some tests to confirm that behaviour by just adding a message in OnDestroy and it was executed two times everytime I deleted an instance of the object. I attached a small model showing that exemple. I am pretty sure it is not a normal behaviour.

Regards!

TestOnDestroy.fsm

Software Version:

FlexSim 23.2.1

user library eventfunctions ondestroy

testondestroy.fsm (35.8 KiB)

Answer 1 · 2023-10-03T17:58:18Z

Phil BoBo answered Oct 3, '23 Matthew Gillespie commented Dec 7, '23

This appears to be caused by a bug-fix with the undo system, where OnDestroy wasn't being called when redoing a delete operation after an undo.

I'll add a case to the dev list to look into fixing this.

In the meantime, I suggest adding some conditional logic to your code to make it robust enough to work when called twice and still work once this gets fixed.

· 1

Matthew Gillespie ♦♦ commented · Dec 07, 2023 at 06:34 PM

@G. Moser This issue is fixed in 24.0.0 released yesterday.

0 ·

question